Skip to content

SearchResultItem: add custom icons#157

Merged
ryonakano merged 15 commits intomainfrom
danirabbit/icons
Jul 17, 2025
Merged

SearchResultItem: add custom icons#157
ryonakano merged 15 commits intomainfrom
danirabbit/icons

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Jul 16, 2025

  • Add custom symbolic icons
  • Set background colors based on place type
Screenshot from 2025-07-15 20 00 10 Screenshot from 2025-07-15 20 23 55

@danirabbit danirabbit requested a review from a team July 16, 2025 01:55
Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks nice. I'm not really poor at design things so really appreciate your hard work!

Leaving just one comment about future

@danirabbit danirabbit requested a review from ryonakano July 16, 2025 17:43
Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nice, leaving some nitpicking comments.

danirabbit and others added 2 commits July 17, 2025 07:09
Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
@danirabbit danirabbit requested a review from ryonakano July 17, 2025 17:14
Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements!

@ryonakano ryonakano enabled auto-merge (squash) July 17, 2025 22:03
@ryonakano ryonakano merged commit e4cf766 into main Jul 17, 2025
3 checks passed
@ryonakano ryonakano deleted the danirabbit/icons branch July 17, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants